Small issue in tcn.py - Githubissues

YuanTingHsieh / TF_TCN

Tensorflow Temporal Convolutional Network

82 stars 39 forks source link

Small issue in tcn.py #4

Closed johnlee09 closed 6 years ago

johnlee09 commented 6 years ago

Hi, Yuan Ting,

Thank you very much for the implementation. Very nice code!

There is a small issue in lines 190 and 196 (tcn.py) where TemporalBlock calls attentionBlock. Values for "counters" and "dropout" should be passed to attentionBlock.

YuanTingHsieh commented 6 years ago

Hi John,

You are right! Thanks for pointing out, I have fixed that in latest commit.