Yubico / Yubico.NET.SDK

A YubiKey SDK for .NET developers
Apache License 2.0
96 stars 48 forks source link

Add support for large RSA keys (3072, 4096) and integrationtest allow-list of valid Yubikeys serials #100

Closed DennisDyallo closed 2 weeks ago

DennisDyallo commented 3 weeks ago

Description

This PR adds support for RSA3072 and RSA4096 keys as well as functioning integration tests for the new key sizes.

Additional changes

It also contains a mandatory allow-list of Yubikey serial numbers to be added in either environment variables or in a configuration file.

This is to prevent users from accidently running integration tests on the wrong keys. The previous block list was removed. Users must add their allowed serial numbers in a allow-list. The allow-list text file should be in the C:\Users\\AppData\Local\Yubico for Windows users and /Users/\<username>/.local/share/Yubico for macOS users.

Miscellaneous changes:

Fixes # YESDK-1300

Type of change

Please delete options that are not relevant.

How has this been tested?

Adding the new functionality and running the integration tests, amending them where needed.

Test configuration:

Checklist:

github-actions[bot] commented 3 weeks ago

Test Results: Windows

    2 files      2 suites   2s :stopwatch: 3 700 tests 3 700 :white_check_mark: 0 :zzz: 0 :x: 3 702 runs  3 702 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9d57e3cc.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 weeks ago

Test Results: Ubuntu

    2 files      2 suites   7s :stopwatch: 3 692 tests 3 692 :white_check_mark: 0 :zzz: 0 :x: 3 694 runs  3 694 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9d57e3cc.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 weeks ago

Test Results: MacOS

    2 files      2 suites   2s :stopwatch: 3 692 tests 3 692 :white_check_mark: 0 :zzz: 0 :x: 3 694 runs  3 694 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9d57e3cc.

:recycle: This comment has been updated with latest results.

DennisDyallo commented 3 weeks ago

Ping @equijano21 adding support for 3072 and 4096 RSA keys

github-actions[bot] commented 2 weeks ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 31% 4257
Yubico.YubiKey 51% 48% 18738
Summary 49% (31945 / 64848) 45% (8176 / 18267) 22995

Minimum allowed line rate is 40%