Yubico / Yubico.NET.SDK

A YubiKey SDK for .NET developers
Apache License 2.0
96 stars 48 forks source link

Add device reset command #110

Closed AdamVe closed 6 days ago

AdamVe commented 1 week ago

Description

Adds command for device reset

Type of change

Please delete options that are not relevant.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test configuration:

Checklist:

github-actions[bot] commented 1 week ago

Test Results: Windows

    2 files      2 suites   4s :stopwatch: 3 700 tests 3 700 :white_check_mark: 0 :zzz: 0 :x: 3 702 runs  3 702 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f1fedc11.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Test Results: Ubuntu

    2 files      2 suites   9s :stopwatch: 3 692 tests 3 692 :white_check_mark: 0 :zzz: 0 :x: 3 694 runs  3 694 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f1fedc11.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

Test Results: MacOS

    2 files      2 suites   3s :stopwatch: 3 692 tests 3 692 :white_check_mark: 0 :zzz: 0 :x: 3 694 runs  3 694 :white_check_mark: 0 :zzz: 0 :x:

Results for commit f1fedc11.

:recycle: This comment has been updated with latest results.

DennisDyallo commented 1 week ago

Is this ready for review @AdamVe ?

DennisDyallo commented 6 days ago

LGTM!

github-actions[bot] commented 6 days ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 31% 4257
Yubico.YubiKey 51% 47% 18867
Summary 49% (31972 / 65274) 45% (8176 / 18345) 23124

Minimum allowed line rate is 40%