Yubico / Yubico.NET.SDK

A YubiKey SDK for .NET developers
Apache License 2.0
96 stars 48 forks source link

Additions for PIN complexity violation #112

Closed AdamVe closed 5 days ago

AdamVe commented 6 days ago

Description

Fw 5.7 adds PIN complexity. With this change the clients can in unified way catch SecurityException from PIV ChangePin/Puk and FIDO2s Set/ChangePin methods.

Fixes # YESDK-1378

Type of change

Please delete options that are not relevant.

How has this been tested?

Added integration tests, tested with device which have PIN complexity enabled. Updated PIV and Fido2 sample applications to handle PIN complexity policy violations.

Checklist:

github-actions[bot] commented 6 days ago

Test Results: Windows

    2 files      2 suites   4s :stopwatch: 3 700 tests 3 700 :white_check_mark: 0 :zzz: 0 :x: 3 702 runs  3 702 :white_check_mark: 0 :zzz: 0 :x:

Results for commit d21c1e64.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 days ago

Test Results: Ubuntu

    2 files      2 suites   9s :stopwatch: 3 692 tests 3 692 :white_check_mark: 0 :zzz: 0 :x: 3 694 runs  3 694 :white_check_mark: 0 :zzz: 0 :x:

Results for commit d21c1e64.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 6 days ago

Test Results: MacOS

    2 files      2 suites   3s :stopwatch: 3 692 tests 3 692 :white_check_mark: 0 :zzz: 0 :x: 3 694 runs  3 694 :white_check_mark: 0 :zzz: 0 :x:

Results for commit d21c1e64.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 5 days ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 31% 4257
Yubico.YubiKey 50% 47% 19089
Summary 49% (31990 / 65940) 44% (8185 / 18519) 23346

Minimum allowed line rate is 40%