Yubico / Yubico.NET.SDK

A YubiKey SDK for .NET developers
Apache License 2.0
96 stars 48 forks source link

Default back to old SCardConnect behavior #83

Closed GregDomzalski closed 1 month ago

GregDomzalski commented 1 month ago

Description

Reverts the change in behavior to open smart card handles exclusively. Instead now defaults back to shared like it was before, but allows for applications to toggle between the new and old behavior through the use of AppContext.SetSwitch.

Fixes #72 and probably #81 as well.

Type of change

Please delete options that are not relevant.

How has this been tested?

Wrote some test code using the TestApp and verified:

Test configuration:

Checklist:

github-actions[bot] commented 1 month ago

Test Results: Windows

    2 files      2 suites   2s :stopwatch: 3 615 tests 3 615 :white_check_mark: 0 :zzz: 0 :x: 3 617 runs  3 617 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9ceeb6a3.

github-actions[bot] commented 1 month ago

Test Results: Ubuntu

    2 files      2 suites   5s :stopwatch: 3 607 tests 3 607 :white_check_mark: 0 :zzz: 0 :x: 3 609 runs  3 609 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9ceeb6a3.

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 32% 4245
Yubico.YubiKey 51% 47% 18417
Summary 49% (31675 / 64299) 45% (8017 / 17967) 22662

Minimum allowed line rate is 40%

github-actions[bot] commented 1 month ago

Test Results: MacOS

    2 files      2 suites   1s :stopwatch: 3 607 tests 3 607 :white_check_mark: 0 :zzz: 0 :x: 3 609 runs  3 609 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9ceeb6a3.

DennisDyallo commented 1 month ago

LGTM