Yubico / Yubico.NET.SDK

A YubiKey SDK for .NET developers
Apache License 2.0
96 stars 48 forks source link

Adding functionality to read and set additional pages of device info #91

Closed DennisDyallo closed 1 month ago

DennisDyallo commented 1 month ago

Description

This PR lets the user set the NFC_RESTRICTED value on the Yubikey by reading the additional pages of data from the Yubikey device info stored on the Yubikey. Additional work is needed to parse and present additional tags.

The change required deprecating the previous way of issuing GetDeviceInfo commands. Deprecated classes:

Fixes # YESDK-1322

Type of change

Please delete options that are not relevant.

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test configuration:

Checklist:

github-actions[bot] commented 1 month ago

Test Results: Windows

    2 files  ±0      2 suites  ±0   2s :stopwatch: ±0s 3 616 tests +1  3 616 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0  3 618 runs  +1  3 618 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit df3476b9. ± Comparison against base commit 5c10887f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results: Ubuntu

    2 files  ±0      2 suites  ±0   5s :stopwatch: ±0s 3 608 tests +1  3 608 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0  3 610 runs  +1  3 610 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit df3476b9. ± Comparison against base commit 5c10887f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results: MacOS

    2 files  ±0      2 suites  ±0   1s :stopwatch: ±0s 3 608 tests +1  3 608 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0  3 610 runs  +1  3 610 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit df3476b9. ± Comparison against base commit 5c10887f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 42% 31% 4257
Yubico.YubiKey 51% 47% 18501
Summary 49% (31624 / 64389) 45% (8038 / 18045) 22758

Minimum allowed line rate is 40%