Yubico / java-webauthn-server

Server-side Web Authentication library for Java https://www.w3.org/TR/webauthn/#rp-operations
Other
457 stars 142 forks source link

Update README for demo server #211

Closed popas90 closed 2 years ago

popas90 commented 2 years ago

The README for the demo server is not mentioning the YUBICO_WEBAUTHN_U2F_APPID envvar, which will cause domain-related errors, if not set. Fixed by adding short explanation on that envvar.

emlun commented 2 years ago

Thanks! But the issue here was rather that there was a default value instead of leaving the setting unset by default. Either way the features that used this were removed in 1f823bc0d6748114e4dcfa719194920e883ea86a, so there's little reason to keep this setting. So this PR is superseded by commit 283e7ebfe84d52bb2623ed265bc9a6fd0dafa78c.