search

Yubico / libfido2

Provides library functionality for FIDO2, including communication with a device over USB or NFC.
Other
590 stars 152 forks source link

Expose user cancelation of the Windows Hello dialog #685

Closed ntwerdochlib closed 1 year ago

ntwerdochlib commented 1 year ago

Additional error mapping ...

Map Windows error codes ERROR_CANCELLED, NTE_USER_CANCELLED to FIDO_ERR_OPERATION_DENIED

LDVG commented 1 year ago

Thank you for the updates! My personal preference would still be to be even more concise in the commit title (for example, GitHub adds an ellipsis at 70 characters, and the Git documentation recommends 50 characters(!) but we need not be that strict). Would you mind updating it again? An example could be just changing "Add support for mapping ..." to "Map ..." or moving some details to the commit body.

ntwerdochlib commented 1 year ago

Thank you for the updates! My personal preference would still be to be even more concise in the commit title (for example, GitHub adds an ellipsis at 70 characters, and the Git documentation recommends 50 characters(!) but we need not be that strict). Would you mind updating it again? An example could be just changing "Add support for mapping ..." to "Map ..." or moving some details to the commit body.

I can see the value in this format and am going to start adopting it in my repos as well.

LDVG commented 1 year ago

I can see the value in this format and am going to start adopting it in my repos as well.

Happy to hear! Once the commit message is amended I'll happily approve this PR.

ntwerdochlib commented 1 year ago

PR comment updated

LDVG commented 1 year ago

For reference, I pushed an amended commit message based on your description that follows the aforementioned guidelines.

Thank you for your contribution!

ntwerdochlib commented 1 year ago

@LDVG Apologies. I actually edited my first comment, not the commit message. Definite sign of genius!! :(

LDVG commented 1 year ago

@LDVG Apologies. I actually edited my first comment, not the commit message. Definite sign of genius!! :(

Don't worry, it happens to the best of us! Thank you again for your work!