search

Yubico / libfido2

Provides library functionality for FIDO2, including communication with a device over USB or NFC.
Other
590 stars 152 forks source link

Improve OpenSSL detection & document requirements #706

Closed ngie-eign closed 1 year ago

ngie-eign commented 1 year ago

The primary goal of this change is to incorporate the CMake module, FindOpenSSL, to allow end-users to better configure which version of OpenSSL they wish to target when building libfido2.

This allows end-users to build on systems with a version of OpenSSL that does not match the default version, e.g., with 3.0.9 on a system that comes with 1.1t by default (FreeBSD 13.2-RELEASE).

While here, document some unmentioned requirements, i.e.,

LDVG commented 1 year ago

Hi,

For my own understanding: is setting PKG_CONFIG_PATH, which we already support, not a sufficient mechanism to achieve the same thing?

Thank you.

ngie-eign commented 1 year ago

Hi,

For my own understanding: is setting PKG_CONFIG_PATH, which we already support, not a sufficient mechanism to achieve the same thing?

Thank you.

Hi @LDVG ! That might work -- I'll need to doublecheck if it does (sometime next week).

LDVG commented 1 year ago

Any updates on this issue? See also #718 (resolved by #719) which ultimately results in CMake also appending CMAKE_PREFIX_PATH, CMAKE_FRAMEWORK_PATH, and CMAKE_APPBUNDLE_PATH to the pkg-config search path.