Yubico / libfido2

Provides library functionality for FIDO2, including communication with a device over USB or NFC.
Other
590 stars 152 forks source link

cmake: bump cmake_minimum_required() #719

Closed LDVG closed 1 year ago

LDVG commented 1 year ago

We are using VERSION_GREATER_EQUAL [1] which was added in CMake 3.7 (released in November 2016). The distributions that we perform releases for are all running at least this version, further substantiated by the fact that we've used this feature since libfido2 1.9.0 (released in October 2021).

Moreover, this change silences a warning on modern CMake versions that compatilibity with versions less than CMake 3.5 is going to be removed in a future CMake release [2].

While here, fix another warning that cmake_minumum_required() has to be called before invoking any other command, see note in [1].

[1] https://cmake.org/cmake/help/latest/command/if.html#version-greater-equal [2] https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html#policy-settings

martelletto commented 1 year ago

LGTM