Yubico / libfido2

Provides library functionality for FIDO2, including communication with a device over USB or NFC.
Other
581 stars 153 forks source link

bio, credman: support non-preview commands #751

Closed LDVG closed 9 months ago

DEX1999 commented 9 months ago

You guys work fast. You answered me about lack of plans for support and that you are welcoming patches. And when i was about to make a PR, i realized that you already make one)

Your changes are almost identical to what we made in our patch, i can confirm that it works with out devices.

When can I expect this to be merged?

LDVG commented 9 months ago

Your changes are almost identical to what we made in our patch, i can confirm that it works with out devices.

Thanks for checking. Out of curiosity, what authenticator are you working on? :slightly_smiling_face:

When can I expect this to be merged?

Given your feedback, this should be possible to merge, pending the usual approval process.

DEX1999 commented 9 months ago

Out of curiosity, what authenticator are you working on? 🙂

Just simple CTAP/WEBAUTHN authenticator, nothing special yet, probably out products will come up with something interesting in future :smile: