Yubico / libfido2

Provides library functionality for FIDO2, including communication with a device over USB or NFC.
Other
581 stars 153 forks source link

Change URL for LibreSSL dependency to avoid issues with the windows build #766

Closed bobomb closed 8 months ago

bobomb commented 8 months ago

Seems like the powershell Invoke-WebRequest command to download LibreSSL is failing - I suspect the URL being used is being blocked, as the URL works fine when opened from a browser, but does not when using Invoke-WebRequest.

I was able to workaround this by changing the URL in windows\const.ps1 from https://cloudflare.cdn.openbsd.org/pub/OpenBSD/LibreSSL to https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/, which works with Invoke-WebRequest

LDVG commented 8 months ago

Hi,

Thanks for the report. What version of Windows are you running? Does the alternate patch below help?

diff --git a/windows/build.ps1 b/windows/build.ps1
index 5ac045b3..c15f315d 100644
--- a/windows/build.ps1
+++ b/windows/build.ps1
@@ -17,6 +17,7 @@ param(

 $ErrorActionPreference = "Stop"
 [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
+[Net.ServicePointManager]::SecurityProtocol += [Net.SecurityProtocolType]::Tls13

 . "$PSScriptRoot\const.ps1"

(We might have to change mirror regardless to accommodate our supported Windows versions. Just want to understand this issue.)

bobomb commented 8 months ago

Hi @LDVG The above patch did not work, the error is the same. I am on Windows 10 21H2 (10.0.19044).

LDVG commented 8 months ago

It'd appear Windows 10 does not support TLS 1.3, and the Cloudflare mirror only offers TLS 1.3 (as tested via openssl s_client). The alternate patch above does work fine on Windows 11 and Windows Server 2022.

I have slightly reworded your patch to reflect this and shortened the commit title, but its contents remain the same (barring the removal of the extra trailing forward slash). If this problem bubbles up again sometime we might have to try a different approach. :-)

Thank you!

bobomb commented 8 months ago

Whoops, didn't mean to accidently close this PR.