Yubico / php-u2flib-server

(OBSOLETE) U2F library in PHP
https://developers.yubico.com/php-u2flib-server/
BSD 2-Clause "Simplified" License
289 stars 68 forks source link

Use native PHP type hints for arrays #33

Closed LukasReschke closed 8 years ago

LukasReschke commented 8 years ago

I'd advocate to use the native PHP type hints where possible. While scalar type hints are not yet possible (except with PHP 7) we can type hint array on our own and make PHP do the error handling.

Same is valid for RegisterRequest which actually is often an array passed around and thus not actually following the PHPDocs. I will see if I can clarify the docs here and make another PR later. Currently the documentation is simply lying :-)