search

Yubico / php-u2flib-server

(OBSOLETE) U2F library in PHP
https://developers.yubico.com/php-u2flib-server/
BSD 2-Clause "Simplified" License
288 stars 68 forks source link

Use __DIR__ instead of getcwd() #36

Closed LukasReschke closed 9 years ago

LukasReschke commented 9 years ago

getcwd() is doomed to fail as soon as the tests are executed from another folder.

Required for https://github.com/Yubico/php-u2flib-server/issues/35

LukasReschke commented 9 years ago

Generally speaking try to avoid getcwd :smile:

klali commented 9 years ago

The changes to phpunit.xml here, are they supposed to be in this commit?

LukasReschke commented 9 years ago

The changes to phpunit.xml here, are they supposed to be in this commit?

Yes. There is no vendor folder here as far I can tell which causes problems with other unit testing tools that try to loop over the folder anyways.

klali commented 9 years ago

Ok.. That was probably added when we used composer more, probably makes sense to drop now. Merging.