Correct handling of errorCode 0

Yubico / php-u2flib-server

(OBSOLETE) U2F library in PHP

https://developers.yubico.com/php-u2flib-server/

BSD 2-Clause "Simplified" License

289 stars 68 forks source link

Correct handling of errorCode 0 #47

Closed Dijky closed 8 years ago

Dijky commented 8 years ago

This library expects a registration/authentication response to not contain the property errorCode (see here and here).

However, an errorCode value of 0 should be considered as OK.

This behaviour currently breaks functionality with (at least) Chrome for Android's implementation, which sets the property errorCode to 0 on success.

MarcStdt commented 8 years ago

I got the same problem. The weird thing is, that only my mobile generates error code 0. Shouldn't be hard to fix.

Regards