Yubico / php-u2flib-server

(OBSOLETE) U2F library in PHP
https://developers.yubico.com/php-u2flib-server/
BSD 2-Clause "Simplified" License
288 stars 68 forks source link

Use common challenge for multiple registrations #55

Closed zauguin closed 7 years ago

zauguin commented 7 years ago

With U2F API v1.1 the same challenge is used for all registrations, so with this it is easier to use this library with the new API.

ChristophWurst commented 7 years ago

cc @klali @LukasReschke as potential reviewers :-)

ChristophWurst commented 7 years ago

Travis CI error seems unrelated. It fails only on php7, looks like a different version of phpunit is installed there which is incompatible with the current tests (they are using namespaced classes now) https://travis-ci.org/Yubico/php-u2flib-server/jobs/229318480

ChristophWurst commented 7 years ago

Travis CI error seems unrelated. It fails only on php7, looks like a different version of phpunit is installed there which is incompatible with the current tests (they are using namespaced classes now) https://travis-ci.org/Yubico/php-u2flib-server/jobs/229318480

I will take a look at this.

klali commented 7 years ago

This looks good to me, planning to merge it but I'd like to land the phpunit fixes in #56 first.

ChristophWurst commented 7 years ago

Hey @klali,

thanks a lot for your quick response and for merging those PRs! Will those changes automatically be published to the composer registry?

ChristophWurst commented 7 years ago

I see the dev-master is already available: https://packagist.org/packages/yubico/u2flib-server#dev-master

klali commented 7 years ago

yeah.. I guess we (I) should make a 1.0.1 release with the last couple of fixes. Would you be helped by a tagged release?

ChristophWurst commented 7 years ago

Yes, that would be great

klali commented 7 years ago

1.0.1 is pushed

ChristophWurst commented 7 years ago

Thanks a lot! I'm already using it here 🚀