search

Yubico / php-u2flib-server

(OBSOLETE) U2F library in PHP
https://developers.yubico.com/php-u2flib-server/
BSD 2-Clause "Simplified" License
289 stars 68 forks source link

Fix examples for Firefox >= 60 and Chrome #71

Closed Julian0815 closed 5 years ago

Julian0815 commented 5 years ago

The examples are not working in Firefox and Chrome. I took a look at the js implementation of https://demo.yubico.com/u2f to fix it. Please review!

klali commented 5 years ago

Thanks for your interest!

Doesn't the u2f-api.js need to change as well, I believe these functions are defined in that?

Julian0815 commented 5 years ago

Hi, I think the u2f-api.js should work in the old version.

klali commented 5 years ago

So u2f-api.js is only used in chrome, so for firefox this will work without it updated. Did you try this update in chrome?

Julian0815 commented 5 years ago

In chromium it works only with the old lib

klali commented 5 years ago

This requires the new u2f-api.js to work in chrome, I'll make that update. Merging this now.

Thanks!