search

Yubico / python-fido2

Provides library functionality for FIDO 2.0, including communication with a device over USB.
BSD 2-Clause "Simplified" License
432 stars 109 forks source link

Fix for when `uv==True` but `clientPin` is not on the device. #190

Closed ashleysommer closed 1 year ago

ashleysommer commented 1 year ago

Fix for _get_auth_params for MakeCredential and GetAssertion operations. Used in cases where _should_use_uv is True, but clientPin is not advertised in CTAP info on the device.

It appears this circumstance was in mind when reading other parts of the code, and checks are already in place. It was just the line in this PR that was overlooked. This forces allow_internal_uv, and everything else then works as expected.

This is fix 1 of 2 for #189

dainnilsson commented 1 year ago

Superseded by #193.