Yubico / python-fido2

Provides library functionality for FIDO 2.0, including communication with a device over USB.
BSD 2-Clause "Simplified" License
432 stars 109 forks source link

Fix packing sub_cmd. #206

Closed polhenarejos closed 8 months ago

polhenarejos commented 1 year ago

sub_cmd is an unsigned char, since VENDOR_PROTOTYPE is 0xff. If not, it cannot be encoded.

Currently, Config.CMD.VENDOR_PROTOTYPE (0xFF) cannot be encoded, since it is encoded as <b (signed char). It must be encoded as <B (unsigned char).

dainnilsson commented 8 months ago

Thanks!