"is" comparison fails with _Reasons.UNSUPPORTED_HASH, use "=="

Yubico / python-fido2

Provides library functionality for FIDO 2.0, including communication with a device over USB.

BSD 2-Clause "Simplified" License

432 stars 109 forks source link

Closed opoplawski closed 4 weeks ago

opoplawski commented 1 month ago

Drop extra call to attestation.verify()

Follow up to #194

dainnilsson commented 1 month ago

Thanks! The extra call to verify() is unneeded, but we do need to re-raise the exception in case the if-statement is false.

opoplawski commented 1 month ago

Thanks! The extra call to verify() is unneeded, but we do need to re-raise the exception in case the if-statement is false.

Ah, good catch. I think this should do it.

dainnilsson commented 4 weeks ago

Thanks again! Merged!