Yubico / python-fido2

Provides library functionality for FIDO 2.0, including communication with a device over USB.
BSD 2-Clause "Simplified" License
432 stars 109 forks source link

Add annotations #45

Closed ziima closed 2 years ago

ziima commented 5 years ago

Annotations would help a lot. Any chance they we can see them soon?

ziima commented 5 years ago

It would most likely require to drop Python 2.7, but its only supported until the end of this year anyway.

dainnilsson commented 5 years ago

We have some typing information in the docstrings, but far from everywhere. Once Python 2 is EOL we'll most likely look at dropping support for it, which would allow us to take advantage of python3-only features.

JohnVillalovos commented 4 years ago

We have some typing information in the docstrings, but far from everywhere. Once Python 2 is EOL we'll most likely look at dropping support for it, which would allow us to take advantage of python3-only features.

Python 2 is now EOL. Does this project care anymore about supporting Python 2? I'm hoping the answer is no 😊

dainnilsson commented 2 years ago

python-fido2 1.0.0rc1 is now released (with final coming in about a month). Support for Python < 3.7 has been dropped, and many annotations as well as type checking through mypy has been added.

ziima commented 2 years ago

Nice :+1: