search

Yubico / python-fido2

Provides library functionality for FIDO 2.0, including communication with a device over USB.
BSD 2-Clause "Simplified" License
432 stars 109 forks source link

WIP: Windows webauthn #78

Closed dainnilsson closed 5 years ago

dainnilsson commented 5 years ago

Continuation of #76.

ITProKyle commented 5 years ago

I have the latest commit to this branch implemented in an app. It is working near flawlessly. I did a 1-for-1 swap of the Fido2Client with the WindowsClient when run on Windows and only ran into one bug (left a comment).

Is there a potential ETA for the release?

dainnilsson commented 5 years ago

Heads up: I've pushed some backwards incompatible changes (see new entry in NEWS).

In short, the Fido2Client API was a bit too CTAP-centric to be cleanly mapped to the Windows API. I've changes it to correspond more to the WebAuthn specification, which also means it matches the Fido2Server API better. Mainly the arguments passed to make_credential and get_assertion are different, see examples/credential.py for example usage.

dainnilsson commented 5 years ago

Is there a potential ETA for the release?

I'm fairly satisfied with this PR, and intend to merge it and create a new release in the 1-2 week time frame. Still want to do some internal testing of the changed APIs.