Do not use comparision with "is" for literals

Tiboris commented 5 years ago

There is a warning with python 3.8 at fedora rawhide about comparision with "is" while running ipa-server install. See: https://bugs.python.org/issue34850

  if mode is 'nand':
/usr/lib/python3.8/site-packages/yubico/yubikey_usb_hid.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif mode is 'and':
/usr/lib/python3.8/site-packages/yubico/yubikey_usb_hid.py:306: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if mode is 'nand':
/usr/lib/python3.8/site-packages/yubico/yubikey_config.py:478: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if slot is 1:
/usr/lib/python3.8/site-packages/yubico/yubikey_config.py:483: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif slot is 2:

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

Tiboris commented 5 years ago

Waiting for #43

dainnilsson commented 5 years ago

Thanks!

Yubico / python-yubico

Do not use comparision with "is" for literals #45