Remove additional wrapper attribute in constructed GET-DATA DOs.

Yubico / ykneo-openpgp

OpenPGP applet for the YubiKey NEO

https://developers.yubico.com/ykneo-openpgp/

GNU General Public License v2.0

215 stars 67 forks source link

Remove additional wrapper attribute in constructed GET-DATA DOs. #21

Closed asheiduk closed 7 years ago

asheiduk commented 9 years ago

Previously GET-DATA wrapped constructed DOs into an attribute with the same tag as the DO. The OpenPGP Card 2.0 does not do this, so some software might be confused. Note that GnuPG effectively ignores any structure inside constructed DOs and is therefore not affected.

jas4711 commented 9 years ago

Thanks for your work! What software are you using to test this with? Is there any way that we can reproduce a problem or test this functionality?

Btw, see #22 which is also about GET-DATA.

asheiduk commented 9 years ago

Indeed #22 solves another issue I've already encountered. Regarding testing: I have written the OpenPGP data extraction script for Cardpeek using the spec and an original OpenPGP 2.0 card. After #21 and #22 have been solved I see no more structural differences between OpenPGP 2.0 card and my Yubikey NEO. You should use however an updated version of the script from my gist here

asheiduk commented 8 years ago

I have updated the patch eliminating the merge conflict.

jonathancross commented 7 years ago

I think @a-dma is now handling PRs.

a-dma commented 7 years ago

Thanks for the effort, merging.