Yubico / ykneo-openpgp

OpenPGP applet for the YubiKey NEO
https://developers.yubico.com/ykneo-openpgp/
GNU General Public License v2.0
214 stars 67 forks source link

WIP: RAM usage reduction #28

Closed promovicz closed 7 years ago

promovicz commented 9 years ago

WORK IN PROGRESS! DO NOT MERGE YET!

The OpenPGP applet currently uses two large buffers, "tmp" and "buffer". The total RAM usage of the applet makes it impossible to install and use it on most common JavaCard models. More specifically only a few JCOP cards have enough memory to run the applet.

After some research I found that "tmp" can be eliminated entirely. This patch series is a work in progress to eliminate it entirely, which in itself is working on my branch.

The "tmp" buffer is used in four places:

My plan is to add additional size checks for added safety.

promovicz commented 9 years ago

I would of course love your comments on this patch and an indication on whether you would merge it once completed.

klali commented 9 years ago

Hello,

Without looking to deeply I'd say that yes, we'd welcome a change like this. Let us know when you believe it's ready to be reviewed and merged.

/klas

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.36%) to 45.09% when pulling 06453080b7e60294c1af69b9183ef1a3f3e54830 on promovicz:ram-usage-reduction into daa0c1094d547a8e846dd24180739d1df8853299 on Yubico:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.62%) to 45.36% when pulling 9c98f737bd9e5eb83813154af255d2f27cad65b3 on promovicz:ram-usage-reduction into daa0c1094d547a8e846dd24180739d1df8853299 on Yubico:master.

jonathancross commented 7 years ago

@promovicz Is this abandoned?

dogtopus commented 7 years ago

Apparently someone else gave it a shot (8f7353dc)