search

Yubico / yubihsm-connector

https://developers.yubico.com/yubihsm-connector/
Apache License 2.0
30 stars 14 forks source link

Vendor fixes #1

Closed nevun closed 5 years ago

nevun commented 5 years ago

The reason the diff is so large is because the vendor github.com/kardianos/service was not recorded in the manifest so we cannot know which version we had so this is the latest kardionos/service and its dependency osext.

..and that one vendor repo was not even used so I removed it.

nevun commented 5 years ago

next step would be "gb vendor update" to update all the vendor code which have not been done since 2018-03.

nevun commented 5 years ago

yubihsm-shell tests pass on linux:

Running tests...
Test project /home/user/yubihsm-shell/build
      Start  1: parsing
 1/25 Test  #1: parsing ..........................   Passed    0.00 sec
      Start  2: pbkdf2
 2/25 Test  #2: pbkdf2 ...........................   Passed    0.01 sec
      Start  3: attest
 3/25 Test  #3: attest ...........................   Passed    0.64 sec
      Start  4: generate_ec
 4/25 Test  #4: generate_ec ......................   Passed    0.50 sec
      Start  5: generate_hmac
 5/25 Test  #5: generate_hmac ....................   Passed    0.41 sec
      Start  6: import_authkey
 6/25 Test  #6: import_authkey ...................   Passed    0.46 sec
      Start  7: import_rsa
 7/25 Test  #7: import_rsa .......................   Passed    0.59 sec
      Start  8: info
 8/25 Test  #8: info .............................   Passed    0.31 sec
      Start  9: wrap
 9/25 Test  #9: wrap .............................   Passed    0.59 sec
      Start 10: wrap_data
10/25 Test #10: wrap_data ........................   Passed    0.39 sec
      Start 11: yubico_otp
11/25 Test #11: yubico_otp .......................   Passed    0.66 sec
      Start 12: echo
12/25 Test #12: echo .............................   Passed    0.38 sec
      Start 13: import_ec
13/25 Test #13: import_ec ........................   Passed    0.54 sec
      Start 14: generate_rsa
14/25 Test #14: generate_rsa .....................   Passed    5.93 sec
      Start 15: logs
15/25 Test #15: logs .............................   Passed    0.50 sec
      Start 16: ssh
16/25 Test #16: ssh ..............................   Passed    0.76 sec
      Start 17: decrypt_rsa
17/25 Test #17: decrypt_rsa ......................   Passed    0.73 sec
      Start 18: decrypt_ec
18/25 Test #18: decrypt_ec .......................   Passed    0.52 sec
      Start 19: import_ed
19/25 Test #19: import_ed ........................   Passed    0.57 sec
      Start 20: change_authkey
20/25 Test #20: change_authkey ...................   Passed    0.52 sec
      Start 21: engine_tests
21/25 Test #21: engine_tests .....................   Passed   41.82 sec
      Start 22: pkcs11test
22/25 Test #22: pkcs11test .......................   Passed  183.56 sec
      Start 23: ecdh_derive_test
23/25 Test #23: ecdh_derive_test .................   Passed    2.71 sec
      Start 24: bash_tests
24/25 Test #24: bash_tests .......................   Passed    7.27 sec
      Start 25: wrapped_tests
25/25 Test #25: wrapped_tests ....................   Passed   25.70 sec

100% tests passed, 0 tests failed out of 25

Total Test time (real) = 276.10 sec

[yubihsm-shell/build]$ 
yubihsm> connect
[LIB - INF 11:17:40.555750] yubihsm.c:4052 (yh_init_connector): Loading http backend
[LIB - INF 11:17:40.572841] yubihsm_curl.c:88 (backend_connect): Trying to connect to http://127.0.0.1:12345/connector/status
[LIB - INF 11:17:40.857522] lib_util.c:129 (parse_status_data): response from connector
[LIB - INF 11:17:40.857578] lib_util.c:130 (parse_status_data): has device: yes
[LIB - INF 11:17:40.857596] lib_util.c:132 (parse_status_data): version: 2.0.0
[LIB - INF 11:17:40.857620] lib_util.c:133 (parse_status_data): pid: 18539
[LIB - INF 11:17:40.857658] lib_util.c:134 (parse_status_data): address: localhost
[LIB - INF 11:17:40.857689] lib_util.c:135 (parse_status_data): port: 12345
[LIB - INF 11:17:40.857732] yubihsm_curl.c:129 (backend_connect): Found working connector
Session keepalive set up to run every 15 seconds
yubihsm> get deviceinfo
[ .. ]
Version number:     2.1.0
$ uname -a
Linux wtf 4.18.0-13-generic #14-Ubuntu SMP Wed Dec 5 09:04:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
nevun commented 5 years ago

All tests also passed with the connector running on macos

$ DEFAULT_CONNECTOR_URL="http://192.xxx.xxx.xxx:8888" make test
Running tests...
Test project /home/user/yubihsm-shell/build
      Start  1: parsing
 1/25 Test  #1: parsing ..........................   Passed    0.00 sec
      Start  2: pbkdf2
 2/25 Test  #2: pbkdf2 ...........................   Passed    0.01 sec
      Start  3: attest
 3/25 Test  #3: attest ...........................   Passed    0.56 sec
      Start  4: generate_ec
 4/25 Test  #4: generate_ec ......................   Passed    0.29 sec
      Start  5: generate_hmac
 5/25 Test  #5: generate_hmac ....................   Passed    0.18 sec
      Start  6: import_authkey
 6/25 Test  #6: import_authkey ...................   Passed    0.23 sec
      Start  7: import_rsa
 7/25 Test  #7: import_rsa .......................   Passed    0.46 sec
      Start  8: info
 8/25 Test  #8: info .............................   Passed    0.03 sec
      Start  9: wrap
 9/25 Test  #9: wrap .............................   Passed    0.38 sec
      Start 10: wrap_data
10/25 Test #10: wrap_data ........................   Passed    0.17 sec
      Start 11: yubico_otp
11/25 Test #11: yubico_otp .......................   Passed    0.47 sec
      Start 12: echo
12/25 Test #12: echo .............................   Passed    0.10 sec
      Start 13: import_ec
13/25 Test #13: import_ec ........................   Passed    0.29 sec
      Start 14: generate_rsa
14/25 Test #14: generate_rsa .....................   Passed    8.67 sec
      Start 15: logs
15/25 Test #15: logs .............................   Passed    0.28 sec
      Start 16: ssh
16/25 Test #16: ssh ..............................   Passed    0.59 sec
      Start 17: decrypt_rsa
17/25 Test #17: decrypt_rsa ......................   Passed    0.65 sec
      Start 18: decrypt_ec
18/25 Test #18: decrypt_ec .......................   Passed    0.27 sec
      Start 19: import_ed
19/25 Test #19: import_ed ........................   Passed    0.36 sec
      Start 20: change_authkey
20/25 Test #20: change_authkey ...................   Passed    0.41 sec
      Start 21: engine_tests
21/25 Test #21: engine_tests .....................   Passed   18.07 sec
      Start 22: pkcs11test
22/25 Test #22: pkcs11test .......................   Passed  127.47 sec
      Start 23: ecdh_derive_test
23/25 Test #23: ecdh_derive_test .................   Passed    3.18 sec
      Start 24: bash_tests
24/25 Test #24: bash_tests .......................   Passed    2.85 sec
      Start 25: wrapped_tests
25/25 Test #25: wrapped_tests ....................   Passed    9.60 sec

100% tests passed, 0 tests failed out of 25

Total Test time (real) = 175.61 sec
nevun commented 5 years ago

Also tested running on Windows.