Remove the device reset, it's causing big performace problems

Yubico / yubihsm-connector

https://developers.yubico.com/yubihsm-connector/

Apache License 2.0

30 stars 13 forks source link

Remove the device reset, it's causing big performace problems #19

Closed qpernil closed 3 years ago

qpernil commented 3 years ago

The status page takes over a minute in a Ubuntu Groovy VM on VMWare ESXi 7.0. With this change 45ms. I don't see any problems with disconnected/reconnected devices.

qpernil commented 3 years ago

python-yubihsm tests pass with this change

qpernil commented 3 years ago

Just a note - This causes performance degradation on a physical Groovy ubuntu machine as well, just not as severe. The diff is 276ms to handle /status on master, and 2ms on the no-reset-device branch

joernheissler commented 3 years ago

I'm using my YubiHSM through an SEH UTN dongleserver (https://www.seh-technology.com/de/produkte/dongleserver.html); a virtual machine (linux inside vmware) is running yubihsm-connector. It did not work without this patch, broke badly on device reset. With the patch it appears to works.

(only tested once with each version).

Thanks and merry xmas!