search

Yubico / yubihsm-connector

https://developers.yubico.com/yubihsm-connector/
Apache License 2.0
31 stars 14 forks source link

Switch to github.com/google/gousb #9

Closed QuLogic closed 5 years ago

QuLogic commented 5 years ago

As noted in #3, there are still two issues:

  1. the ZLP is not sent anymore, you can test that with yubihsm-shell by executing plain echo 3 61. I did some digging and it's gousb that doesn't allow sending an empty buffer.
  2. Errors out when resetting a device. If you run the tests in pytnon-yubihsm it will fail when the tests reset the device (don't run these tests on a production device!).

But as I don't own any devices, I really have no idea how to fix these. Any ideas would be welcome.

Fixes #3.

QuLogic commented 5 years ago

I'm able to run both python-yubihsm and yubihsm-shell tests without issue now, though I can't seem to get yubihsm-shell to work from the command-line itself (which confuses me since its tests work.)

syntaxcase commented 5 years ago

Hi, nice work. It looks good to me and I want to merge it, just going through some more tests. Is this code contributed under this repository license (Apache 2.0)?

QuLogic commented 5 years ago

Yes.

syntaxcase commented 5 years ago

Merged, thanks for your contribution!