Yubico / yubikey-manager

Python library and command line tool for configuring any YubiKey over all USB interfaces.
https://developers.yubico.com/yubikey-manager/
BSD 2-Clause "Simplified" License
879 stars 126 forks source link

Allow running against keyring-25 #612

Closed mkszuba closed 4 months ago

mkszuba commented 6 months ago

At the moment, i.e. up to and including the current state of the main Git branch, yubikey-manager depends on keyring < 25. However, running the 5.4.0 test suite - including integration tests against a dedicated YK5 - produces no errors against keyring-25.1.0 (i.e. the latest version currently available from PyPI), and I have yet to observe any run-time errors of this configuration. I would therefore like to suggest removing this version cap.

Steps to reproduce

Expected result

yubikey-manager pulls keyring-25, installs fine, passes all tests and produces no run-time errors during normal use.

Actual results and logs

yubikey-manager pulls keyring-24.3.1.

Other info

The aforementioned testing has been conducted against a py3.11 venv configured not to use system site-packages.

dainnilsson commented 4 months ago

This is resolved in the latest version (5.5.0).