search

Yubico / yubikey-personalization-gui

YubiKey Personalization GUI
https://developers.yubico.com/yubikey-personalization-gui
BSD 2-Clause "Simplified" License
198 stars 38 forks source link

yubikeylogger.cpp:237: possible bad if test ? #36

Closed dcb314 closed 10 years ago

dcb314 commented 10 years ago

[src/yubikeylogger.cpp:237]: (style) Expression is always false because 'else if' condition matches previous condition at line 235.

Source code is

} else if(mode == YubiKeyConfig::Mode_ChalRespHmac) {
    return(tr("Challenge-Response: Yubico OTP"));
} else if(mode == YubiKeyConfig::Mode_ChalRespHmac) {
    return(tr("Challenge-Response: HMAC-SHA1"));

Suggest code rework.