search

Yubico / yubikey-personalization

YubiKey Personalization cross-platform library and tool
https://developers.yubico.com/yubikey-personalization/
BSD 2-Clause "Simplified" License
300 stars 82 forks source link

typo in Makefile.am #61

Closed fischli closed 9 years ago

fischli commented 9 years ago

there is an typo in Makefile.am and the relative path prefix to libhmac.la is missing

index 79f9c95..a99fed5 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -58,10 +58,10 @@ libykpers_1_la_SOURCES += ykpers-nojson.c
 endif
 libykpers_1_la_SOURCES += ykpers_lcl.h ykpers-json.h ykpers_lcl.c
 libykpers_1_la_SOURCES += ykpers-1.pc.in libykpers-1.map
-libykpers_1_la_LIBADD = $(LTLIBYUBIKEY) ./ykcore/libykcore.la libhmac.la $(libjson_LIBS)
+libykpers_1_la_LIBADD = $(LTLIBYUBIKEY) ./ykcore/libykcore.la ./libhmac.la $(libjson_LIBS)
 libykpers_1_la_LDFLAGS = -no-undefined \
        -version-info $(LT_CURRENT):$(LT_REVISION):$(LT_AGE)
-EXTRA_libykpers_1_la_DEPENDENCIES = libykpers-1.map
+libykpers_1_la_DEPENDENCIES = libykpers-1.map

 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = ykpers-1.pc
klali commented 9 years ago

The dependency on libykpers-1.map is supposed to be for EXTRA_libykpers_1_la_DEPENDENCIES otherwise the generated libykpers_1_la_DEPENDENCIES is overwritten with it

I'm going to close this issue with the fix to make libhmac relative. this also relates to issue #62 since EXTRA_ is added in automake 1.11.3