search

Yubico / yubikey-piv-manager

Tool for configuring your PIV-enabled YubiKey
https://developers.yubico.com/yubikey-piv-manager/
GNU General Public License v3.0
39 stars 7 forks source link

Inconsistent licensing #35

Closed opoplawski closed 6 years ago

opoplawski commented 6 years ago

COPYING is GPLv3+, but licensecheck reports both GPLv3+ and BSD:

BSD (2 clause)
--------------
yubikey-piv-manager-1.4.2/pivman/yubicommon/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/ctypes/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/__init__.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/exe.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/setup/qt.py

BSD (3 clause)
--------------
yubikey-piv-manager-1.4.2/pivman/yubicommon/ctypes/libloader.py

GPL (v3 or later)
-----------------
yubikey-piv-manager-1.4.2/man/pivman.1
yubikey-piv-manager-1.4.2/pivman/__init__.py
yubikey-piv-manager-1.4.2/pivman/__main__.py
yubikey-piv-manager-1.4.2/pivman/controller.py
yubikey-piv-manager-1.4.2/pivman/libykpiv.py
yubikey-piv-manager-1.4.2/pivman/messages.py
yubikey-piv-manager-1.4.2/pivman/piv.py
yubikey-piv-manager-1.4.2/pivman/piv_cmd.py
yubikey-piv-manager-1.4.2/pivman/storage.py
yubikey-piv-manager-1.4.2/pivman/utils.py
yubikey-piv-manager-1.4.2/pivman/view/__init__.py
yubikey-piv-manager-1.4.2/pivman/view/generate_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/init_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/main.py
yubikey-piv-manager-1.4.2/pivman/view/manage.py
yubikey-piv-manager-1.4.2/pivman/view/set_key_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/set_pin_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/settings_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/usage_policy_dialog.py
yubikey-piv-manager-1.4.2/pivman/view/utils.py
yubikey-piv-manager-1.4.2/pivman/watcher.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/classes.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/osx.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/settings.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/utils.py
yubikey-piv-manager-1.4.2/pivman/yubicommon/qt/worker.py
yubikey-piv-manager-1.4.2/setup.py

Perhaps this could be clarified or made consistent.

emlun commented 6 years ago

Hi! Thanks for asking. The BSD licensed files are from the vendor/yubicommon submodule, which is a separate software package.

It might indeed be a good idea to make this clearer by for example placing the yubicommon files in a lib subdirectory or such, but that is not a priority at this time.

opoplawski commented 6 years ago

Well, it's inconsistent even within yubicommon, so I've filed https://github.com/Yubico/python-yubicommon/issues/11 Thanks.