Yubico / yubikit-android

Yubico Mobile Android SDK - YubiKit
Apache License 2.0
102 stars 38 forks source link

Update Spotbugs GitHub action #144

Closed AdamVe closed 3 days ago

AdamVe commented 3 days ago
  1. Bumps the versions of spotbugs and spotbugs gradle plugin to most recent.

  2. Forces true result for the spotbugs invocations (in the sarif files this is a property in runs[].invocations called executionSuccessful). The reason is that there is a bug in find-sec-bugs which causes warnings/errors similar to

    The following classes needed for analysis were missing:
    call
    invoke

    and makes the invocation to fail (with exit code 3 and execution successful false). Github is reading the value of executionSuccessful and reports it as

    image

    Forcing execution successful to true removes the error status and we can still browse all the reports in the security scanning view.