search

Yubico / yubikit-android

Yubico Mobile Android SDK - YubiKit
Apache License 2.0
103 stars 38 forks source link

OTPListener interface not accessible outside the com.yubico.yubikit.otp package #19

Closed tonydailallscripts closed 4 years ago

tonydailallscripts commented 4 years ago

I created a Xamarin binding for Yubikit and otp packages. I am unable to implement the interface since it does not have an access modifier and it defaults to private. I made it public in my local repository and it resolves the issue.

imakhalova commented 4 years ago

Valid point. Please feel free to submit pull request with this change.

tonydailallscripts commented 4 years ago

I do not have commit privileges.

ludwigward commented 4 years ago

Thank you for your feedback! We are investigating if the change would have any unwanted effects and will accommodate the change in the next RC, which is currently planned for end of next week.

Feel free to reach out if you have any further feedback or questions.

dainnilsson commented 4 years ago

After some investigation we determined that this class and some other related ones shouldn't be extended by the user, and some access modifiers have been changed to reflect that.