Yubico / yubikit-android

Yubico Mobile Android SDK - YubiKit
Apache License 2.0
103 stars 38 forks source link

Implementation of device utility methods #44

Closed AdamVe closed 2 years ago

AdamVe commented 2 years ago

In this PR:

Requirements:

The new methods should have same functionality as

  1. https://github.com/Yubico/yubikey-manager/blob/next/ykman/device.py#L613
  2. https://github.com/Yubico/yubikey-manager/blob/next/ykman/device.py#L518

Testing

No automated tests yet. All test are being done manually and the results are being compared to result outputs from existing Yubico apps (Yubikey Manager on Desktop)

dainnilsson commented 2 years ago

Can you add a package-info.java like this one: https://github.com/Yubico/yubikit-android/blob/master/oath/src/main/java/com/yubico/yubikit/oath/package-info.java to the package? This serves to make all variables non-nullable unless explicitly annotated as Nullable.