Yubico / yubikit-android

Yubico Mobile Android SDK - YubiKit
Apache License 2.0
102 stars 38 forks source link

[Android 13][OtpActivity] NFC scan hangs after detecting yubikey #79

Closed marcin-michalek-miquido closed 1 year ago

marcin-michalek-miquido commented 1 year ago

Hello,

I think there is a bug in the SDK on Andorid 13. I use the SDK UI (OtpActivity) + activity result callback.

I prepared a minimal repo that reproduces the issue: https://github.com/marcin-michalek-miquido/yubikoAndroid13

1) I click "scan" 2) The SDK dialog appears 3) I put a NFC key in range 4) SDK dialog detects it (label changes to "Remove key" + a sound) 5) SDK dialog freezes on that state not returning the result

Expected: 5) The SDK dialog closes and notifies the result callback in activity

Note: on the same devices when I plug the Yubikey using USB C the SDK works as expected - the issue is only with NFC.

So far it happens only on Android 13 (tested on Pixel 6 Pro and Pixel 5). Also tested the same app from above repo on Android 12 and 11 using NFC and it works as expected.

Could you please confirm / fix?

AdamVe commented 1 year ago

Thanks for reporting, I can reproduce this in the AndroidDemo SDK demo application in master. I confirm your report that this occurs only on devices running Android 13.

AdamVe commented 1 year ago

@marcin-michalek-miquido #80 should fix the issue, I verified in your minimal repro project as well in AndroidDemo SDK app.

marcin-michalek-miquido commented 1 year ago

Great, thanks for a fast fix! Do you plan to release a new artifact version soon?

AdamVe commented 1 year ago

We are hoping to make a release sometime in January 2023.

AdamVe commented 1 year ago

Fixed in release 2.2.0