Yubico / yubikit-android

Yubico Mobile Android SDK - YubiKit
Apache License 2.0
115 stars 42 forks source link

Add core.internal.Logger #94

Closed AdamVe closed 1 year ago

AdamVe commented 1 year ago

We are in the state of deprecating core.Logger class in favor of slf4j. Internally in the libraries we use adapting calls (Logger.debug(logger, msg) etc.) which were added into the public Logger interface. This works great, but creates a lot of warnings that the libraries use deprecated class. The amount of the warnings might cause that we overlook an important warning.

This PR moves out the methods into a new internal class. This effectively removes the warnings when using core.internal.Logger.debug(logger, msg) and similar calls.

This class has a javadoc informing that it should not be used by applications and is in a new internal package. It will be removed together with the deprecated core.Logger in the next major library release.