search

Yubico / yubikit-ios

Yubico Mobile iOS SDK - YubiKit
Apache License 2.0
194 stars 43 forks source link

YubiKitDeviceCapabilities.supportsMFIAccessoryKey incorrect on iPad Pro 6th Gen #126

Closed jbickerton closed 1 year ago

jbickerton commented 1 year ago

YubiKitDeviceCapabilities.supportsMFIAccessoryKey is returning true for latest iPad device, when the device does not provide support for this (has USB-C not lightning).

WWSellers commented 1 year ago

What is the model ID of your iPad? (example: iPad8,1) Maybe the list in this method needs to be updated. +[YubiKitDeviceCapabilities supportsMFIAccessoryKey] https://github.com/Yubico/yubikit-ios/blob/main/YubiKit/YubiKit/YubiKitDeviceCapabilities.m

or the model mapping needs to be updated https://github.com/Yubico/yubikit-ios/blob/main/YubiKit/YubiKit/Helpers/Additions/UIDeviceAdditions.m (i see the file is missing the current M2 iPads: iPad14,3 , iPad14,4 , iPad14,5 , iPad14,6 )

WWSellers commented 1 year ago

Does this mean you are seeing issues when your app tries to call startAccessoryConnection()?

jensutbult commented 1 year ago

FYI both startAccessoryConnection() and startSmartCardConnection() are safe to be called even if the device doesn't support them. startAccessoryConnection() will hit an Assert in debug builds on unsupported devices though but not in production.