search

Yubico / yubikit-ios

Yubico Mobile iOS SDK - YubiKit
Apache License 2.0
199 stars 47 forks source link

Fixes #135 - iPhone 15 Pro #136

Closed joeblau closed 1 year ago

joeblau commented 1 year ago

Summary:

The code for supportsSmartCardOverUSBC (YubiKitDeviceCapabilities.m:127) maintains a table of known devices with USB-C, which has not yet been updated yet.

Device model strings are mapped to yubikit constants in ykf_setupDeviceModel (UIDeviceAdditions.m:22).

This pull request does 3 things.

  1. Adds the device names for iPhone 15 and iPhone 15 Pros.
  2. Adds support for NFC connectivity to iPhone 15 and iPhone 15 Pro.
  3. Adds support for USB-C connectivity to iPhone 15 and iPhone 15 Pro

Manual Tests: Ran this code manually on my iPhone 15 Pro

image

Unit Tests: This library doesn't have existing tests for these features

jensutbult commented 1 year ago

@joeblau could you please sign your commits?

jensutbult commented 1 year ago

We need all commits to be signed to be able to merge these changes.

jensutbult commented 1 year ago

I've resigned your commits and merged the changes. Thanks for your contribution!