search

Yubico / yubikit-ios

Yubico Mobile iOS SDK - YubiKit
Apache License 2.0
195 stars 43 forks source link

Architecture Request: switch to XCFramework instead of static libraries #63

Open msmtamburro opened 3 years ago

msmtamburro commented 3 years ago

With Xcode 12, there are some additional lipo steps needed to deal with static libraries, such as the one created with the Yubico Xcode project. If you were to instead use an XCFramework, consumers of this code wouldn't have to remove architectures prior to submitting apps.

jensutbult commented 3 years ago

Is there a specific reason that you can not use the Swift Package Manager for our SDK? That's the method we currently encourage our integrators to use as it is very user friendly and nicely integrated into Xcode.

msmtamburro commented 3 years ago

Thanks for responding. Yes, our current tooling constructs our Xcode projects on the fly, and does not yet support the Swift Package Manager. I figured I would ask, since you have an existing framework target, but understand if you cannot accommodate the request.

jensutbult commented 3 years ago

Is it possible for you to include the source code in your current tooling instead of the libraries? The reason I'm asking is that we're contemplating removing the binary distribution of the SDK. Nothing is set in stone yet so input from users of the SDK is highly valuable.

jensutbult commented 3 years ago

I think if we do decide to keep the binary distribution a move to XCFramework would probably make a lot of sense.

msmtamburro commented 3 years ago

Thanks, Jens. For us, including source code requires some maintenance if files are added, removed, renamed, or moved. Since that's more work than lipo, we've opted to do this post-processing step on the framework.

jensutbult commented 3 years ago

Do you have a time frame as to when support for SPM might be included in you tooling? If this is something that is planned, keeping the current static libraries and then moving to SPM might be a better route than adding support for XCFramework in YubiKit.

msmtamburro commented 3 years ago

Hi Jens-- No, SPM support is neither on our roadmap, nor the open source project on which our tooling is based.

jensutbult commented 3 years ago

Ok, good to know. We'll keep this issue open for now and reevaluate once version 4 of our SDK has been released.

mrdeakapants commented 2 years ago

I could use a hand in creating some apps from scratch using Xcode and some other things I have around the house like I want to design an app that will unlock apple phones and also that will unlock any other phones but lets start with cracking the apple a bit first and if you can help me out guys I would greatly appreciate it and all the proceeds can be shared or whatever but I am so new at the creative side of the apple that I just really need a hand with the writing of the programs and getting my foot in the door here thanks