YubiKit 4.0.0 requires minimum iOS 13.0, but podspec says iOS 11

Yubico / yubikit-ios

Yubico Mobile iOS SDK - YubiKit

Apache License 2.0

195 stars 43 forks source link

YubiKit 4.0.0 requires minimum iOS 13.0, but podspec says iOS 11 #76

Closed WWSellers closed 2 years ago

WWSellers commented 3 years ago

the podspec file specifies iOS 11

s.ios.deployment_target = '11.0'

But attempting to run in any version of iOS 12 will fail with:

dyld: Library not loaded: /System/Library/Frameworks/CryptoTokenKit.framework/CryptoTokenKit Referenced from: /Users/username/Library/Developer/CoreSimulator/Devices/2E9560E2-BBDD-4328-8B0A-AEBB81F71E35/data/Containers/Bundle/Application/3692A730-7193-41E8-8EF5-28DD4F9F2918/VmwarePIV-D.app/Frameworks/YubiKit.framework/YubiKit Reason: image not found

bmwalters commented 2 years ago

@jensutbult @WWSellers this should be able to be closed since 4.2.0 has released. Thanks for working on this.

WWSellers commented 2 years ago

Is it really ok to close this? On inspecting the YubiKit.podspec file for version 4.2.0, it still targets iOS 11, but does not mark CryptoTokenKit as weak for ios 11 and 12

s.weak_framework = 'CryptoTokenKit'

jensutbult commented 2 years ago

The dependency on CryptoTokenKit has been removed altogether from YubiKit so no need to specify it as weak.

WWSellers commented 2 years ago

OK. Thanks