Mhynlo commented 5 years ago

Note: There is a system call that uses API 21 (released 2014)

I used the recreate() method to help the theme transition in the settings section (current screen), but closing the app and reopening helps display the theme that was selected.

dainnilsson commented 5 years ago

Thanks for your contribution! Before merging this there are a few issues which need to be addressed:

Since this requires API 21 the setting to switch theme should be hidden on older versions, the new code should only be run on devices with API 21 or later.
There are several colors in the dark theme that need to be changed for visibility. I just had a quick look, but some examples of where I found problems are:
- The timer bar is almost invisible, as it's dark blue on dark gray.
- Titles in some dialogs are white test on white background, making them invisible.
When switching theme, before restarting, you get a mix where some screens use one theme and others use the other. The whole app should switch at once, either immediately (ideally) or on restart.

Mhynlo commented 5 years ago

I was able to get the themes handled better with this last commit.

I did not find a great way to implement that third item.

dainnilsson commented 5 years ago

Thanks! Regarding the third item, I can take a stab at that!