search

Yucked / Victoria

🌋 - Lavalink wrapper for Discord.NET. Provides more options and performs better than all .NET Lavalink libraries combined.
https://github.com/Yucked/Victoria/wiki
193 stars 48 forks source link

[Bug]: Equalizer does not propagate updates? #135

Closed ivanbiljan closed 1 year ago

ivanbiljan commented 1 year ago

Describe your issue in as much detail as possible

I'm using the equalizer as a bass booster. Boosting works fine, however resetting a boosted stream does not. See image below: image

Setting the boost to BassBoost.High produces expected results with audios such as https://www.youtube.com/watch?v=ft5X5wVBcYQ&ab_channel=UltimateBassBooster, i.e. ,there's a noticeable difference in the strength of the bass.

However, if I try to revert to original state by setting the boost to None (0 gain) nothing happens

Version

v5 (Latest)

Version

GitHub's latest

Relevant log output

No response

Yucked commented 1 year ago

Unsure if it gets ignored because 0.0 is default value. Try -0.1 and see if that works

ivanbiljan commented 1 year ago

Right, I saw the JsonIgnore, however I forgot to mention that I tried going from -0.25 to 0.35 and that didn't work either unfortunately

ivanbiljan commented 1 year ago

For whatever it's worth I just tested this against the v6 branch and it seems to work as intended

Yucked commented 1 year ago

If it's working on v6 then it's all good. v5 won't be maintained anymore