Yucked / Victoria

🌋 - Lavalink wrapper for Discord.NET. Provides more options and performs better than all .NET Lavalink libraries combined.
https://github.com/Yucked/Victoria/wiki
193 stars 48 forks source link

[ BUG ] Some video make Victoria throw a silent exception, making all event not tigger anymore #140

Closed AlexandreBazeaud closed 1 year ago

AlexandreBazeaud commented 1 year ago


Describe the bug/issue.

Exception is produced at LavaNode.cs line 363, the data received contain unparsable json. When this silent exception is thrown (because JsonDocument.Parse is not in the try catch) any event going forwards will not be handled at all, forcing a restart of the all application.

Stacktrace / Screenshots

image

Solution

The bug seems to be reproducable 100% using this link https://www.youtube.com/watch?v=Ksl04qNkkRM, encodedTrack is too big and bufferSize is too small, causing the Json received to miss mandatory characters to be parsable, the solution is to increase BufferSize

Yucked commented 1 year ago

fixed in recent commit