Yue-Jiang / pzfx

Read and write 'Graphpad Prism' '.pzfx' files in R
https://yue-jiang.github.io/pzfx/
Other
14 stars 5 forks source link

Decimal point vs comma in numeric data #9

Closed mschubert closed 3 years ago

mschubert commented 3 years ago

Thank you for the package, it's nice to be able to load collaborators' Prism file into R!

I've got a minor locale issue: in some countries (e.g. Germany, Netherlands) the decimal point . is represented by a , instead.

Unfortunately, Prism (at least version 8.0.0.131 with PrismXMLVersion=5.00) seems to save the comma instead of the point to its files.

As such, when I read the files, I'm getting character columns instead of numeric columns.

Would it be possible for the package to parse this automatically?

Yue-Jiang commented 3 years ago

interesting! this is definitely new knowledge to me. would you be able to provide a small example file? then i can make sure the problem is fixed. thanks!

mschubert commented 3 years ago

Please find a sample file with a single numeric value attached

```xml Project info 1 Experiment Date2020-11-02 Experiment ID Notebook ID Project Experimenter Protocol Data 1 parental untreated 3,5
```
Yue-Jiang commented 3 years ago

@mschubert Thanks for providing the test file. i just included a fix, let me know if installing from github fixes the problem.