Yufannnn / CS2103T-Practical-Exam

0 stars 0 forks source link

Inconsistent Behaviours for new application Usage or corrupted data. #14

Open Yufannnn opened 1 year ago

Yufannnn commented 1 year ago

When the data is corrupted, the app with start with an empty list. While if the data is starting for the first time, the app with started with a sample patient list. This inconsistency may lead to potential confusion to the users.

Screenshot 2023-04-14 150259.png

nus-pe-bot commented 1 year ago

Team's Response

Hi!

Thank you for your input! This design was intentional.

Having sample data when the app is started for the first time is intended to give new users an idea of how to use the app and how it would look like when populated with data.

On the other hand, we do not see a need to load sample data if the user's data file is corrupted, since a user trying to import their own data is unlikely to need sample data as a guide. In fact, it might be misleading as it might appear that the user's data file has been loaded correctly, the incorrectness of the data only being noticed upon closer inspection. Moreover, starting with an empty list would prompt the user to check their data source.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the explanation, I understand your rationale now and I think this design is okay. However, if we adopt this design, the problem now is that when the user starts with an empty person list because of a corrupted data file, there is no warning message shown and the users may be confused about what happened. What is worse, if they do some operations in this situation, their maybe-slightly-corrupted file would be overwritten.