adding option menu to ActivitySavedRules

YuhanXu / omnidroid

Automatically exported from code.google.com/p/omnidroid

Apache License 2.0

0 stars 0 forks source link

adding option menu to ActivitySavedRules #111

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

context menu or option menue?

Original issue reported on code.google.com by sv767%ny...@gtempaccount.com on 4 Jul 2010 at 3:45

GoogleCodeExporter commented 8 years ago

Original comment by sv767%ny...@gtempaccount.com on 4 Jul 2010 at 3:46

Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

I'll work on this.

Original comment by case.and...@gmail.com on 5 Jul 2010 at 3:51

Changed state: Started

GoogleCodeExporter commented 8 years ago

do you wanna discuss it before you start coding?

Original comment by sv767%ny...@gtempaccount.com on 5 Jul 2010 at 4:31

GoogleCodeExporter commented 8 years ago

Awaiting Codereview: http://codereview.appspot.com/1700051/show

Original comment by case.and...@gmail.com on 6 Jul 2010 at 12:04

GoogleCodeExporter commented 8 years ago

Salome, Sorry, I was coding a good portion of the day and didn't notice you had 
commented.  Just let me know what you might disagree with on the codereview and 
we'll discuss there.  :-)~  Thanks!

P.S. I added you as a CC on this (remove if not interested).  Thanks!

Original comment by case.and...@gmail.com on 6 Jul 2010 at 1:40

GoogleCodeExporter commented 8 years ago

Original comment by case.and...@gmail.com on 6 Jul 2010 at 2:19

GoogleCodeExporter commented 8 years ago

btw I was checking this on the device, and I love it.

Original comment by salomeju...@gmail.com on 14 Jul 2010 at 3:05

GoogleCodeExporter commented 8 years ago

Thanks.  In that case, you should give my code review approval.  :-)

Original comment by case.and...@gmail.com on 14 Jul 2010 at 3:11

GoogleCodeExporter commented 8 years ago

no don't you have to add notifications on/off, and also pop-up on toggle on/off?

Original comment by sv767%ny...@gtempaccount.com on 14 Jul 2010 at 3:37

GoogleCodeExporter commented 8 years ago

I don't really understand the notifications on/off.  Isn't that controlled 
system wide via Settings?

What do you mean pop-up on toggle on/off?  Toasting that each rule is 
enabled/disabled?

Original comment by case.and...@gmail.com on 14 Jul 2010 at 3:45

GoogleCodeExporter commented 8 years ago

no, if you enable rule when omnidroid is disabled, you need to notify user. but 
maybe eli's suggestion in i127 would be enough.

Original comment by sv767%ny...@gtempaccount.com on 14 Jul 2010 at 4:33

GoogleCodeExporter commented 8 years ago

Yeah, I wasn't planning to address that in this issue, that's why I opened up 
issue 127 about it.  I'd prefer to commit this code and address pop-ups in a 
separate issue  if Issue 127 doesn't take care of it.

Original comment by case.and...@gmail.com on 14 Jul 2010 at 1:49

GoogleCodeExporter commented 8 years ago

r812

Original comment by case.and...@gmail.com on 15 Jul 2010 at 1:27

Changed state: Fixed