Yujun-Shi / DragDiffusion

[CVPR2024, Highlight] Official code for DragDiffusion
https://yujun-shi.github.io/projects/dragdiffusion.html
Apache License 2.0
1.13k stars 82 forks source link

A confusion between the formula and the code #25

Closed Aziily closed 1 year ago

Aziily commented 1 year ago

Hello, I am trying to understand your excellent work

But as far as I am concerned, according to the formula in the paper as below $h_i^{k+1}=\text{arg}\min||F_q(\hat{zt}^{k+1})-F{h_i^k}(z_t)||$ Is the code here should be https://github.com/Yujun-Shi/DragDiffusion/blob/3a88d93e97cbb1863d73a98b577b639bd4020b8a/drag_utils.py#L31C33-L31C33 f0 = F0[:, :, int(pi[0]), int(pi[1])] instead of f0 = F0[:, :, int(pi0[0]), int(pi0[1])]?

I wonder if it is my wrong understanding, hope for your answer

Yujun-Shi commented 1 year ago

Hello, thanks for your interests in our work! Actually, this is a typo in our report. The code is the correct implementation. Thanks again for pointing out the typo in our report. We will revise this in our later version.

I'm closing this issue for now, and feel free to re-open it if you have any more questions.