Yuki-Inoue / jupyter_on_rails

Integrate Rails and Jupyter
MIT License
83 stars 11 forks source link

Follow deprecation hint and favor environment variable JUPYTER_DATA_DIR over --ipython-dir flag #11

Closed rstammer closed 4 years ago

rstammer commented 5 years ago

Hi @Yuki-Inoue, thanks for your great work! I really enjoy using it. Here's a fix for a tiny cosmetic issue: When starting the kernel with rake jupyter:notebook, we observe a deprecation warning:

--ipython-dir is deprecated. Use JUPYTER_DATA_DIR environment variable instead.

This PR just follows the hint and makes use of the env variable JUPYTER_DATA_DIR instead of the --ipython-dir flag. However, passing the env var IPYTHONDIR is still working, too. What do you think?

edit: I've seen you've already opened an issue, so this one is tackling #10