Attributes height and width not working in code block

YukiGasai / obsidian-google-calendar

Add Google Calendar inside Obsidian

https://yukigasai.github.io/obsidian-google-calendar/

GNU General Public License v3.0

359 stars 25 forks source link

Attributes height and width not working in code block #172

Open sVerentsov opened 1 year ago

sVerentsov commented 1 year ago

I am making a kind of dashboard and would like to have an ability to set the height and width of the timeline.

I see that there are parameters for that in the readme, however they are not working properly. I forked the repo and added passing these parameters from TimeLineView то TimeLine and TimeLineHourText.

However, in #160 you said that this parameter is deprecated. Is there any reason why these parameters are deprecated or should I make a PR?

YukiGasai commented 1 year ago

Hi, I decided that the width and height values are not that useful because, when using the views as codeblock it will always take the full width anyway. But If there are some cases where this could be useful, we can fix it. PRs are always welcome ^^.

kkartch0 commented 11 months ago

I don't have a use for adjusting width, but adjusting height and allowing for overflow and a scroll box as explained by @Waun on discussion item #185 would be great.

oo3mL commented 7 months ago

Hi, I decided that the width and height values are not that useful because, when using the views as codeblock it will always take the full width anyway. But If there are some cases where this could be useful, we can fix it. PRs are always welcome ^^.

Here's an example of where I would love to be able to set the height and scale of a view. With the amount of meetings and reminders I have, it would be helpful to have a better view.